Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix move interactivity schema to supports property instead of selectors property #59166

Merged
merged 1 commit into from Feb 19, 2024

Conversation

fabiankaegy
Copy link
Member

What?

Moves the interactivity subproperty from the selectors property to the supports

Why?

Because the property is a block support option. It was missplaced before.

How?

By copying it to the correct spot.

@fabiankaegy fabiankaegy added the [Type] Developer Documentation Documentation for developers label Feb 19, 2024
@fabiankaegy fabiankaegy self-assigned this Feb 19, 2024
Copy link

github-actions bot commented Feb 19, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
Co-authored-by: gziolo <gziolo@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Flaky tests detected in f69f2d6.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7955660862
📝 Reported issues:

Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Aside: the verification in integration tets for core blocks and the block supports in the schema doesn’t seem to strict as it didn’t help to catch this mistake.

@fabiankaegy
Copy link
Member Author

@gziolo yeah I'm pretty sure that is because the supports property has the additional properties option allowed. So anything is valid there.

@fabiankaegy fabiankaegy merged commit d673498 into trunk Feb 19, 2024
64 checks passed
@fabiankaegy fabiankaegy deleted the fix/block-json-schema-interactive-support branch February 19, 2024 07:36
@github-actions github-actions bot added this to the Gutenberg 17.8 milestone Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants