Apply hover styles to filter chip while being configured #59236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
Needs Design Feedback
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +61 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
I may be missing important details, but the before and after images look identical to me. |
ntsekouras
approved these changes
Feb 21, 2024
|
@jasmussen to clarify; currently when a filter configuration popover is open the chip has the default appearance, IE it looks identical to all other chips. On this PR the hover style is retained while the popover is open, to create further visual connection between the chip and the popover. The hover style may need to be stronger, but that's probably a detail to finesse in a dedicated PR. |
|
Oh I see it now, the blue hover color is slightly darker. I'm fine with moving forward, but I do think the change is barely perceptible, which usually means we shouldn't do it, or increase the differential a little bit. |
|
Happy to try a stronger hover / active treatment. This is about as strong as we can get without running into contrast issues: 
|
|
Flaky tests detected in 5824d99. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8006332075
|
|
Nice. |
getdave
pushed a commit
that referenced
this pull request
Feb 27, 2024
Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
|
I just cherry-picked this PR to the cherry-pick-wp-6-5-beta-3 branch to get it included in the next release: 3bf1514 |
getdave
added
Backported to WP Core
9 tasks
getdave
pushed a commit
that referenced
this pull request
Feb 27, 2024
Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Apply hover styles to filter chip while the filter is being configured.
Why?
Further helps connect the popover with the associated chip. This will become more important as more filters are added.
How?
Target the
aria-expandedattribute and style accordingly.Testing Instructions
We might try a stronger visual indicator than the hover state, but this felt a reasonable place to start.