Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: Add missing empty space to print out valid HTML. #59255

Merged
merged 2 commits into from Feb 22, 2024

Conversation

juanfra
Copy link
Member

@juanfra juanfra commented Feb 21, 2024

What?

Adding an empty space to have the navigation block producing valid HTML.

Fixes #59238

Why?

Because if not, there are two attributes together.

How?

Adding an empty space.

Testing Instructions

  1. Open a site with TT4.
  2. Set up a navigation menu.
  3. Visit the front end, view the page source, and confirm that there's an empty space between data-wp-interactive="core/navigation" and the following data attribute of the nav element.
Screenshot 2024-02-21 at 19 23 45

@juanfra juanfra added [Type] Bug An existing feature does not function as intended [Block] Navigation Affects the Navigation Block [Feature] Interactivity API API to add frontend interactivity to blocks. labels Feb 21, 2024
Copy link

github-actions bot commented Feb 21, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @gyurmey2.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: gyurmey2.

Co-authored-by: juanfra <juanfra@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: huzaifaalmesbah <huzaifaalmesbah@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@huzaifaalmesbah
Copy link
Contributor

I tested your PR, and it successfully addressed the issue. nice work

Huzaifa-20240222081758

@juanfra juanfra self-assigned this Feb 22, 2024
Copy link

Flaky tests detected in c95a2ee.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8002508355
📝 Reported issues:

@juanfra juanfra added the Backport to WP Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Feb 22, 2024
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @juanfra!

@juanfra juanfra merged commit c9faf06 into trunk Feb 22, 2024
59 checks passed
@juanfra juanfra deleted the fix/59238-nav-interactivity-space branch February 22, 2024 19:40
@github-actions github-actions bot added this to the Gutenberg 17.9 milestone Feb 22, 2024
getdave pushed a commit that referenced this pull request Feb 27, 2024
Unlinked contributors: gyurmey2.

Co-authored-by: juanfra <juanfra@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: huzaifaalmesbah <huzaifaalmesbah@git.wordpress.org>
@getdave
Copy link
Contributor

getdave commented Feb 27, 2024

I just cherry-picked this PR to the cherry-pick-wp-6-5-beta-3 branch to get it included in the next release: 266b4d2

@getdave getdave added Backported to WP Core Pull request that has been successfully merged into WP Core and removed Backport to WP Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta labels Feb 27, 2024
getdave pushed a commit that referenced this pull request Feb 27, 2024
Unlinked contributors: gyurmey2.

Co-authored-by: juanfra <juanfra@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: huzaifaalmesbah <huzaifaalmesbah@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported to WP Core Pull request that has been successfully merged into WP Core [Block] Navigation Affects the Navigation Block [Feature] Interactivity API API to add frontend interactivity to blocks. [Type] Bug An existing feature does not function as intended
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Lack of spaces in HTML (nav block)
4 participants