Font Library: Hide UI elements when user lacks permissions #59332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creativecoder
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Note that this code was originally developed in #58957, so the following contributors should be credited in the commit message for this PR. |
This was referenced Feb 23, 2024
|
Size Change: +84 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
creativecoder
added
the
Backport to WP Beta/RC
mikachan
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Thanks for pulling these changes out into their own PR! I agree that this display logic makes sense regardless of the decisions around any new capabilities.
This smoke tests well for me and I think it's ready to bring in. I'm happy for the automated tests to be worked on separately over in #59316, I don't want that to be a blocker here.
|
|
||
| if ( ! canUserCreate ) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
Given that we will render the upload tab only if canUserCreate, is this needed?
There was a problem hiding this comment.
Removed here: 29d01c4
There was a problem hiding this comment.
Sorry for the late response. I added the additional check based on the concern expressed here about the component being reused elsewhere and missing the check:
There was a problem hiding this comment.
If the component is going to be re-used, it can be added later. It will probably require more work than that check, and that's out of the scope of this PR.
matiasbenedetto
approved these changes
Feb 28, 2024
|
Thanks for the reviews and assist. I'll set this to merge once tests pass. |
youknowriad
added a commit
that referenced
this pull request
Mar 4, 2024
Co-authored-by: creativecoder <grantmkin@git.wordpress.org> Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org> Co-authored-by: mikachan <mikachan@git.wordpress.org> Co-authored-by: peterwilsoncc <peterwilsoncc@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: swissspidy <swissspidy@git.wordpress.org> Co-authored-by: getdave <get_dave@git.wordpress.org>
|
I just cherry-picked this PR to the update/packages-6.5-rc1 branch to get it included in the next release: bd2eeec |
youknowriad
added
Backported to WP Core
youknowriad
added a commit
that referenced
this pull request
Mar 4, 2024
Co-authored-by: creativecoder <grantmkin@git.wordpress.org> Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org> Co-authored-by: mikachan <mikachan@git.wordpress.org> Co-authored-by: peterwilsoncc <peterwilsoncc@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: swissspidy <swissspidy@git.wordpress.org> Co-authored-by: getdave <get_dave@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Hides selected UI elements from the Font Library interface when a user lacks the permissions necessary to create or delete fonts.
Why?
Related to #55280
Ensures that the Font Library UI works as expected when
wp_font_familypermissions are customized.How?
Testing Instructions
Add the following to your site