Font library: Update the spacing in the font collection panel #59357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matiasbenedetto I've tried to fix the layout shift in the font collection panels but there is now a visible shift in the width of the category selection instead. |
carolinan
added
[Type] Enhancement
|
Size Change: +6 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
matiasbenedetto
added
the
Backport to WP Beta/RC
matiasbenedetto
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
@matiasbenedetto I've tried to fix the layout shift in the font collection panels but there is now a visible shift in the width of the category selection instead.
That's unrelated to this PR, and it is caused by different contents (different categories) in the categories select component. That's out of the scope of this PR.
Regarding the problem this PR is about, it is working as advertised, so I'm approving it.
Thanks for the fix.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
pushed a commit
that referenced
this pull request
Mar 4, 2024
…#59357) Co-authored-by: carolinan <poena@git.wordpress.org> Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org>
|
I just cherry-picked this PR to the update/packages-6.5-rc1 branch to get it included in the next release: df0c480 |
youknowriad
added
Backported to WP Core
youknowriad
pushed a commit
that referenced
this pull request
Mar 4, 2024
…#59357) Co-authored-by: carolinan <poena@git.wordpress.org> Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow-up to #59205 #59036
Adjusts the spacing at the top of the font collection panel, to account for the height of the dropdown menu button.
Why?
When you switched between the Google Fonts panel and another font collection panel there was a visible layout shift at the top of the panel.
How?
Places both the heading and the description inside a VStack inside the existing Hstack, which means that the height of the dropdown menu button no longer affects the vertical position of the two texts.
Testing Instructions
Switch between the two font collection panels: Google Fonts and "My Custom Collection".
Screenshots or screencast
Before:
2024-02-23.13-02-11.mp4
After:
font-library-collection.mp4