New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Button: Fix focus outline in disabled primary variant #59391
Conversation
6066676
to
a0dbce2
Compare
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: -17 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good find! Looks good and works well 🚀
Thank you for the review and a great comparison image 😊 |
Fixes #58632
What?
This PR fixes the focus style of a
Button
component with the following three props;variant="primary"
disabled
__experimentalIsFocusable
Why?
Only this pattern seems to have different values for the box-shadow style.
How?
I applied the same focus style as the other patterns.
Testing Instructions
run storybook:e2e:dev
.http://localhost:50241/?path=/story/components-button--variant-states
.Testing Instructions for Keyboard
Same
Screenshots or screencast
In the screenshot below, all buttons have focus.
Before
After