fix: Outline selected, failed Gallery block items #59423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcalhoun
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.71 MB ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
dcalhoun
force-pushed
the
fix/outline-selected-failed-gallery-items
branch
from
70d652a
to
4d20eeb
Compare
Indicate which Gallery block item is selected, even when an individual item is has an in-progress, paused, or failed media upload.
dcalhoun
force-pushed
the
fix/outline-selected-failed-gallery-items
branch
from
4d20eeb
to
95e5ea0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Indicate which Gallery block item is selected, even when an individual
item is has an in-progress, paused, or failed media upload.
Why?
Fixes #59392. Avoids confusion as to which item is selected.
How?
Remove conditional logic removing the selection outline when the item's upload
is in-progress, paused, or failed.
This logic was originally added in #18493, as referenced above, but the original
intent for disabling for in-progress or failed uploads is not clear.
Testing Instructions
Testing Instructions for Keyboard
N/A, no changes to the user flow.
Screenshots or screencast
gallery.select.outline.mp4