Refactor: useBlockTools cleanup #59450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.71 MB ℹ️ View Unchanged
|
Mamaduka
reviewed
Feb 29, 2024
| const _showEmptyBlockSideInserter = | ||
| clientId && | ||
| ! isTyping() && | ||
| editorMode === 'edit' && | ||
| isUnmodifiedDefaultBlock( { name, attributes } ); | ||
| isUnmodifiedDefaultBlock( block ); |
There was a problem hiding this comment.
Let's reuse isEmptyDefaultBlock here.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
selectedBlockClientIds() does quite a bit more work, when we only need one of the selected block ids. Generally, this will only be one block id. In the case of multiples, the previous method would get the topmost block in the selection in the array. getBlockSelectionStart gets the block where selection starts, which is a slightly different concept. Functionally, I think the outcome is identical, and getBlockSelectionStart should be faster.
draganescu
force-pushed
the
refactor/selected-block-data
branch
from
53db6c6
to
616d285
Compare
draganescu
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Is there anything holding this back outside an approving review? I pushed @Mamaduka 's nit and a comment about why we don't use the most likely selector.
| } = select( blockEditorStore ); | ||
|
|
||
| const selectedBlockClientIds = getSelectedBlockClientIds(); | ||
| const selectedBlockClientId = selectedBlockClientIds[ 0 ]; | ||
| const selectedBlockClientId = getBlockSelectionStart(); |
There was a problem hiding this comment.
Do you think adding a comment of why this is used (perf) instead of the selector that has the name matching the variable name is something future us will like?
There was a problem hiding this comment.
I don't think someone would want to change this unless they knew why they were changing it, so maybe it's OK without the comment.
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
selectedBlockClientIds() does quite a bit more work, when we only need one of the selected block ids. Generally, this will only be one block id. In the case of multiples, the previous method would get the topmost block in the selection in the array. getBlockSelectionStart gets the block where selection starts, which is a slightly different concept. Functionally, I think the outcome is identical, and getBlockSelectionStart should be faster. Co-authored-by: Andrei Draganescu <andrei.draganescu@automattic.com> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow-up to #58979. @Mamaduka proposed some good ideas for improvements, but I wanted to do them in follow-ups instead of putting the changes into the first refactor.
Why?/How?
isUnmodifiedDefaultBlockby passing the full block object.getBlockSelectionStart()instead ofselectedBlockClientIds()Testing Instructions
Toolbar should work in the same way as before.