New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
l10n: Unify terminology to screen size
#59456
Conversation
Size Change: -2 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
ResponsiveBlockControl, | ||
__experimentalResponsiveBlockControl as ResponsiveBlockControl, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor fix: While preparing this PR, I realized that this code example does not work. This component is exported with a __experimental prefix.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked into this and "Screen sizes" is the more common form in general writing and communication, whereas "screensizes" is generally used in programming for the purpose of brevity. Therefore we should lean into the non-compound version.
Thanks for the PR.
Fixes #58192
What?
This PR unifies the two mixed variations (
screen size(s)
/screensize(s)
) intoscreen size(s)
.Why?
To improve terminology consistency.
How?
I'm not a native English speaker, but it seems like everything is unified by "screen size(s)" in the core.
Testing Instructions
This PR causes a visual change only for the
ResponsiveBlockControl
component. Although this component is public, it doesn't seem to be used anywhere in the Gutenberg project. If used, it would look like this: This is a temporary rewrite of the code block.Code