List: copy wrapper when multi selecting items #59460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
reviewed
Feb 29, 2024
| @@ -27,6 +29,7 @@ export const settings = { | |||
| }; | |||
| }, | |||
| transforms, | |||
| [ unlock( privateApis ).requiresWrapperOnCopy ]: true, | |||
There was a problem hiding this comment.
Does this implicitly expose the block's new configuration? Or do we need to add new support like __unstableRequiresWrapperOnCopy to block.json, similar to __unstablePasteTextInline etc?
There was a problem hiding this comment.
For example, when I copied and pasted Button, Column, etc. that depend on the parent block, I found that the block could not be pasted like this problem. I imagine that similar problems can be solved by adding it as block support.
8e662ccb71cffea62cfb1017b2560d0b.mp4
There was a problem hiding this comment.
Does this implicitly expose the block's new configuration?
What do you mean? How is it exposed? You need the key to be able to retrieve it.
Sure, we could add it to column and button in the same way. I still prefer using a symbol until we properly stabilise it.
There was a problem hiding this comment.
For example, developers may discover and use this new key when creating custom blocks. Since it is a private API, is it okay not to take that into account?
There was a problem hiding this comment.
Since it is a private API, is it okay not to take that into account?
Sorry, I'm not sure what you mean by not taking it into account? Since it's a private symbol, you can't access or set it unless you have know to the symbol (unlike strings).
There was a problem hiding this comment.
I see, then there's no problem. Maybe I didn't understand what a Symbol was 😅
|
Size Change: +117 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
t-hamano
approved these changes
Feb 29, 2024
|
Thanks @t-hamano! |
annezazu
added
the
Backport to WP Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Mar 4, 2024
Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org>
|
I just cherry-picked this PR to the update/packages-6.5-rc1 branch to get it included in the next release: 13e2c3f |
youknowriad
added
Backported to WP Core
youknowriad
pushed a commit
that referenced
this pull request
Mar 4, 2024
Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #59381. The problem is that the logic setting the wrapper does not execute when there a multi selection of list items, because it's based on a ref and event listeners.
Why?
Fixes #59381.
How?
Add a block type setting and check inside
setClipboardBlocksinstead, which will work for both single and multi selection.Testing Instructions
Added a test that fails in trunk. press cmd+a twice in a list to select all list items, then paste into an empty paragraph.
Testing Instructions for Keyboard
Screenshots or screencast