Dataviews: Fix sticky table headers #59467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Enhancement
|
Size Change: -43 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
t-hamano
reviewed
Mar 1, 2024
There was a problem hiding this comment.
Thanks for the PR!
The following is how it looks on Windows OS / Chrome, and it appears to be working as expected.
a320668039e4297fede76569576663fb.mp4
However, we may need to increase the z-index of the table header so that the checkbox is not in front:
With this approach the filter controls are also sticky where previously it was only the table headers. I haven't found an approach that avoids this yet, but perhaps it's useful?
Personally, I would expect the filter control to be fixed, but I think it might be a good idea to make the filter control fixed on all layouts.
packages/dataviews/src/dataviews.js
Outdated
Comment on lines
94
to
95
| <div className="dataviews-wrapper"> | ||
| <VStack spacing={ 3 } justify="flex-start"> | ||
| <VStack spacing={ 0 } justify="flex-start"> |
There was a problem hiding this comment.
I'm thinking maybe we can remove this nested div. That is, it would look like this:
return (
<VStack
className="dataviews-wrapper"
spacing={ 0 }
justify="flex-start"
>
<HStack />
<ViewComponent />
<Pagination />
</VStack>
);
Personally I think that we might want to explore this more before merging, because right now the filters are few, but could be lots of them in the future. I know it's not quite easy though, from all the things I tried and searched.. |
|
I agree with you both, fixing the filter controls can be useful, but in cases where there are many active filters there's potential for clunkiness. As an extreme (but realistic) example, here are the filters a user might enact on orders in WooCommerce, on an iPad mini viewport size: 
You could argue this is an edge case not worth optimising for. And that some dimensions could be massaged at this breakpoint (the sidebar takes over a third of the horizontal space 😱). A couple of tweaks can go a long way: 
But clearly the filters are still accounting for a lot of space. Let's see what other designers have to say. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
@ntsekouras Seems unlikely we can merge this with 100% confidence for 6.5, and it may be too late now. Do you think we should spin up a separate PR to remove the 'broken' sticky styles for 6.5? |
We could yes, but this would mean reverting this PR and bring back the issue it solved. If that's okay with you, let's do it. |
|
I think I've cracked it. @t-hamano was on the right path, consolidating some of the wrappers seems to be the key.
sticky.mp4 |
ntsekouras
approved these changes
Mar 5, 2024
ntsekouras
added
[Type] Bug
getdave
pushed a commit
that referenced
this pull request
Mar 11, 2024
Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org> # Conflicts: # packages/dataviews/src/style.scss
|
I just cherry-picked this PR to the pick/wp-65-rc-2 branch to get it included in the next release #59756 |
getdave
added
Backported to WP Core
getdave
pushed a commit
that referenced
this pull request
Mar 12, 2024
Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org> # Conflicts: # packages/dataviews/src/style.scss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58977.
sticky.mp4
Testing Instructions
filter bar, table headers, and pagination stickWith this approach the filter controls are also sticky where previously it was only the table headers. I haven't found an approach that avoids this yet, but perhaps it's useful? We can discuss that and investigate alternative approaches in this PR.