Global Styles: Use text and button background color for color indicators #59514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
the
Global Styles
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +29 B (0%) Total Size: 1.73 MB
ℹ️ View Unchanged
|
|
I do like that these are more representative of the application of style, rather than the palettes themselves. |
|
What alternative would you want to try? |
If the button background color is the same as the text color then we should try to find an alternative IMO |
|
@scruffian @richtabor What about user-defined, something like below. With fallbacks as already proposed? Note the |
|
@bgardner I would prefer that we don't add more APIs just for the sake of the preview. What about if we used the first 2 colors from the palette, that aren't the background/text colors? |
|
@scruffian Isn't that what is happening now? For context, here is what my Variation previews currently look like:
|
Oh yeah I think you're right! |
But they're arbitrary; there may be a color in the style selector that isn't used prominently, which results in an unclear response if the style was successfully applied. And the colors could likely clash/blend in visually with the background color of the site/selector, making it less clear and less encouraging of a selection. |
richtabor
added
[Type] Enhancement
|
I rebased this to pull in the latest changes. |
|
Flaky tests detected in f4e4a5c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8543716245
|
richtabor
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
LGTM. Let's follow up to explore how theme authors can choose specific colors for their previews as well (still maintaining this as the fallback): #59444 (comment)
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
…59514) Co-authored-by: scruffian <scruffian@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org> Co-authored-by: bgardner <bgardner@git.wordpress.org> Co-authored-by: mtias <matveb@git.wordpress.org> Co-authored-by: spencerfinnell <spencerfinnell@git.wordpress.org>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Changes the color indicators for style panels.
Fixes #59444.
Why?
The aim is to make the color palette selection clearer, but I'm not yet convinced this is the right solution.
How?
The two colors are
styles.text.colorandstyles.elements.button.background.Testing Instructions
Screenshots or screencast
Before:
After:
