Global Styles: Remove filter for same number of settings #59590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -34 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
ajlende
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
I was going to say the code looked in need of a bit of a refactor, but it seems you've already don that in #59588.
This is what I see. I'm guessing the heading is different because I didn't bother merging with trunk to test because of the conflicts and I'm running a version of trunk newer than this change.
Colors
| Before | After |
|---|---|
 |
 |
Typography
| Before | After |
|---|---|
 |
 |
It all looks good to me 👍
scruffian
force-pushed
the
remove/global-styles-filtering
branch
from
b446223
to
eb11f01
Compare
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When we show presets for typography and colors in Global Styles, we filter out variations where there are no color or typography changes in the settings. This removes that filter.
Why?
I think there are legitimate reasons why a style variation wouldn't change the settings, but would still change other aspects of the styles. For example in TT3 this filter prevents and typography presets showing, because all the fonts are defined in the parent variation.
How?
Just removes the filter.
Testing Instructions
Screenshots or screencast