Polish Google Fonts consent box. #59631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +17 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
matiasbenedetto
approved these changes
Mar 6, 2024
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
matiasbenedetto
added
[Feature] Font Library
Backport to WP Beta/RC
|
@jasmussen Was this to fix a bug in the layout of this panel that was identified during RC? I ask because we're now in the RC period and we should only be backporting bugs identified during RC or that are critical to the functioning of one of the features. I'm going to remove the Backport label for now unless someone feels strongly otherwise. |
getdave
removed
the
Backport to WP Beta/RC
bph
added
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This updates the Google Fonts consent box to be closer to the initial mockups. That means a correct line height, font size, font weight, box width, and box padding.
Before:
After:
This PR also fixes what I believe was an accessibility bug; the heading level was 3, but with the modal being the preceding heading with a level of 1, I believe this level should be 2.
Testing Instructions