Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inline comment denoting version for Ruby setup #59640

Conversation

Jayanth-Parthsarathy
Copy link
Contributor

What?

Add version number as comment for ruby setup in rnmobile-ios-runner.yml

Why?

Fixes #59624. This PR adds a human-readable comment denoting the version number for the Ruby setup in the rnmobile-ios-runner.yml file. This enhances readability and helps maintain consistency with GitHub security hardening guidelines.

How?

The PR adds an inline comment following the recommendation outlined in GitHub security hardening guidelines. This comment provides clarity on the version of Ruby being used in the workflow setup.

Testing Instructions

  1. Navigate to the rnmobile-ios-runner.yml file.
  2. Locate the Ruby setup step.
  3. Verify that a comment denoting the version number is present.

Testing Instructions for Keyboard

N/A

Screenshots or screencast

image

Copy link

github-actions bot commented Mar 6, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Jayanth-Parthsarathy <jayanthparthsarathy@git.wordpress.org>
Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Mar 6, 2024

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Jayanth-Parthsarathy! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Mar 6, 2024
Copy link
Contributor

@desrosj desrosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@desrosj desrosj added the [Type] Build Tooling Issues or PRs related to build tooling label Mar 9, 2024
@desrosj
Copy link
Contributor

desrosj commented Mar 9, 2024

Before merging this @Jayanth-Parthsarathy, could you create a w.org account and link your GitHub profile to it? The details how to do that are here.

@Jayanth-Parthsarathy
Copy link
Contributor Author

Jayanth-Parthsarathy commented Mar 9, 2024

I have linked my wordpress account to my github account @desrosj .

@Jayanth-Parthsarathy
Copy link
Contributor Author

Hey @desrosj any updates on this? Glad to make any changes if needed

@desrosj
Copy link
Contributor

desrosj commented Mar 13, 2024

No changes needed. Sorry for the delay, I was traveling home after WordCamp Asia.

@desrosj desrosj merged commit 2515c83 into WordPress:trunk Mar 13, 2024
59 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.0 milestone Mar 13, 2024
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Mar 27, 2024
Co-authored-by: Jayanth-Parthsarathy <jayanthparthsarathy@git.wordpress.org>
Co-authored-by: desrosj <desrosj@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add inline comment denoting action version
2 participants