Add support "HTML Element" to Site Tagline #59654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torounit
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
torounit
changed the title
|
Size Change: +3.99 kB (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
t-hamano
reviewed
Mar 9, 2024
There was a problem hiding this comment.
Thanks for the PR!
I'm thinking of adding this UI to the block toolbar, following other blocks (comments-title, post-title, query-title, site-title). For example, the Site Title block also supports the paragraph as well as headings:
In other words, the implementation should look like this:
- Use
HeadingLevelDropdowncomponent - Define the
levelattribute as anumbertype. This is because theHeadigLevelDropdowncomponent deals with a number. - Level
0is treated as a "paragraph"
|
Thanks! Fixed to use |
t-hamano
approved these changes
Mar 11, 2024
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
* add tagName to attributes * update fixture * use HeadingLevelDropdown * update site-tagline * fix json * Update packages/block-library/src/site-tagline/index.php Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> --------- Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
* add tagName to attributes * update fixture * use HeadingLevelDropdown * update site-tagline * fix json * Update packages/block-library/src/site-tagline/index.php Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> --------- Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add TagName attribute and control for site-tagline Block.
Why?
ref: #59523
How?
Add Inspector Controls
Testing Instructions
1 add tagline block.
2 open Advanced Settings.
3 Change HTML element.
Testing Instructions for Keyboard
Screenshots or screencast