New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quote: show as active when deeply nested child block is selected #59662
Conversation
Size Change: -3 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
When editing a quote block, and it doesn't have the
citation
attribute set, the "Add citation" UI is shown only when the quote block or an inner paragraph block is selected:However, this doesn't work when a nested block is selected, like when editing a nested Quote -> List -> List Item:
Here the "Add citation" UI should be also visible, but it isn't.
This PR fixes this by calling the
hasSelectedInnerBlock
with adeep=true
parameter.I'm also fixing a dependency array of
useSelect
call -- it should contain theclientId
value that is used inside the callback.