Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing for date and time typing for TextControl #59666

Merged
merged 4 commits into from Mar 7, 2024

Conversation

J0n-92
Copy link
Contributor

@J0n-92 J0n-92 commented Mar 7, 2024

What?

Adding the new types for the TextControl Component as describled in issue 59544

Why?

Fix for 59544

How?

Adding new types to allow date, time and datetime-local to the types.ts file

@J0n-92 J0n-92 requested a review from ajitbohra as a code owner March 7, 2024 07:12
Copy link

github-actions bot commented Mar 7, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: J0n-92 <jon092@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Mar 7, 2024
Copy link

github-actions bot commented Mar 7, 2024

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @J0n-92! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@J0n-92 J0n-92 changed the title Add typing for date and time Add typing for date and time typing for TextControl Mar 7, 2024
@mirka mirka added [Type] Enhancement A suggestion for improvement. [Package] Components /packages/components props-bot Adding this label triggers the Props Bot workflow for a PR. labels Mar 7, 2024
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Mar 7, 2024
Copy link
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@mirka mirka enabled auto-merge (squash) March 7, 2024 07:52
@mirka mirka merged commit 6f5fc1b into WordPress:trunk Mar 7, 2024
55 of 56 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.0 milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Components /packages/components [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants