Fix return icon viewbox. #59669
Merged
Fix return icon viewbox. #59669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -22 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
t-hamano
approved these changes
Mar 9, 2024
There was a problem hiding this comment.
LGTM!
If this misalignment occurs due to PR, either the button was not aligned vertically in the first place, or it was adjusted using a CSS hack, so I think the icon position itself is correct. Let's fix these issues in follow-ups.
Link Control
The button position is incorrect in the first place.
| Before | After |
|---|---|
 |
 |
Inline Link
Need to remove this CSS hack
| Before | After |
|---|---|
 |
 |
Social Link Block
The button position is incorrect in the first place.
| Before | After |
|---|---|
 |
 |
Inline Image Width
Correct
| Before | After |
|---|---|
 |
 |
Image Block: Insert from URL
Correct
| Before | After |
|---|---|
 |
 |
|
Thanks, I'll look at a CSS hack removal PR as a followup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #58555. Corrects a buggy viewbox.
Testing Instructions
Observe the link-dialog before and after, the carriage return icon should slightly shift places:
The button actually looks slightly misaligned inside the link dialog now, but that's a separate issue.