Use viewScriptModule block.json field for interactivity e2e tests #59705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirreal
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This comment was marked as resolved.
This comment was marked as resolved.
|
I think I've fixed or ignored the lints correctly. |
gziolo
reviewed
Mar 8, 2024
packages/e2e-tests/plugins/interactive-blocks/directive-bind/view.asset.php
Show resolved
Hide resolved
gziolo
reviewed
Mar 8, 2024
|
Nice refactoring, I don't know the codebase so I will leave the approval to more experienced folks 👍🏻 |
sirreal
force-pushed
the
update/use-viewscriptmodule-in-interactivity-e2e
branch
from
c7bad45
to
d7329fd
Compare
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
…rdPress#59705) The interactivity end-to-end test blocks were manually registering and enqueuing view modules. They also erroneously included (unregistered) viewScript handles. viewScriptModule is a clean and simple way to handle registration and enqueue for these assets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Use viewScriptModule to for assets in the interactivity end-to-end test plugin.
Why?
The interactivity end-to-end test blocks were manually registering and enqueuing view modules.
They also erroneously included (unregistered) viewScript handles.
viewScriptModule is a clean and simple way to handle registration and enqueue for these assets.
How?
"viewScript": "…"to `"viewScriptModule": "file:./view.js"view.asset.phpfiles.render.phpfiles.Testing Instructions
The e2e tests should continue to pass.