New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Support for menu group to the Dropdown #59723
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +520 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
Looks good to me. Will refer to Marin for the ✅! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find 👍 thanks @enejb 🙌
Left a couple of minor suggestions on cleaning the story up a bit, should be good to go after addressing them.
This could likely use a CHANGELOG entry, something like the PR name would work.
🚀
Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
* Add: Support for menu group to the Dropdown * Remove the duplicate scss * Remove the DropdownContentWrapper in story Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com> * remove comment Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com> * Remove the DropdownContentWrapper in story Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com> * Update Changelog --------- Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com> Co-authored-by: enejb <enej@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
Before:
After:
What?
This PR adds nicer styling for the MenuGroup component when it is places inside the DropDown menu,
Why?
This make the default styling of the MenuGroup much nicer when it is places inside the DropDown component.
How?
This PR just adds additional styles for MenuGroup to the DropDown menu.
Testing Instructions
Start Storyboard
npm run storybook:dev
Open the http://localhost:50240/?path=/story/components-dropdown--with-menu-items
Visit
http://localhost:50240/?path=/story/components-dropdownmenu--with-children notice that it still looks the same.
Screenshots or screencast