Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block JSON schema: Add layout.allowCustomContentAndWideSize field #59736

Merged

Conversation

t-hamano
Copy link
Contributor

@t-hamano t-hamano commented Mar 10, 2024

Related to #56236

What?

This PR adds a supports.layout.allowCustomContentAndWideSize field to the schema of block.json.

Why?

To enhance the developer experience.

Testing Instructions

Create a JSON file like the one below and open it in a code editor.

{
	"$schema": "https://raw.githubusercontent.com/WordPress/gutenberg/block-schema/add-allow-custom-content-and-wide-size/schemas/json/block.json",
	"name": "test/test",
	"title": "Test",
	"supports": {
		"layout": {}
	}
}

You should see allowCustomContentAndWideSize reference.

Screenshots or screencast

image

@t-hamano t-hamano added the [Type] Developer Documentation Documentation for developers label Mar 10, 2024
@t-hamano t-hamano self-assigned this Mar 10, 2024
@t-hamano t-hamano marked this pull request as ready for review March 10, 2024 12:41
Copy link

github-actions bot commented Mar 10, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this :)

@fabiankaegy fabiankaegy merged commit 17ef9a6 into trunk Mar 10, 2024
65 checks passed
@fabiankaegy fabiankaegy deleted the block-schema/add-allow-custom-content-and-wide-size branch March 10, 2024 13:43
@github-actions github-actions bot added this to the Gutenberg 18.0 milestone Mar 10, 2024
@t-hamano
Copy link
Contributor Author

@fabiankaegy Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants