Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextareaControl: Remove extra closing curly brace in inputStyleNeutral #59744

Merged
merged 1 commit into from Mar 19, 2024

Conversation

SahilThakur02
Copy link
Contributor

Fixed Syntax Error in CSS Component

Hello Gutenberg Contributors!

I'm excited to present my contribution to the project with this pull request. In this PR, I addressed a syntax error that was affecting the 'inputStyleNeutral' CSS component. By removing an extra curly brace, I ensured the proper functioning of this component.

What?

The primary focus of this PR was to fix the syntax error in the 'inputStyleNeutral' CSS component.

Why?

This fix was necessary to maintain the integrity and functionality of the CSS component within Gutenberg.

How?

To resolve the issue, I carefully reviewed the code and removed the unnecessary curly brace in the 'inputStyleNeutral' CSS component.

Testing Instructions

I have provided step-by-step instructions for testing this PR:

  1. Open a post or page.
  2. Insert a heading block.
  3. Verify the behavior of the 'inputStyleNeutral' CSS component.

Additionally, for keyboard accessibility testing:

  1. Navigate to a post or page.
  2. Insert a heading block using keyboard navigation.
  3. Confirm the functionality of the 'inputStyleNeutral' CSS component with keyboard-only interactions.

Your feedback and review of this contribution are highly appreciated. Together, we can continue to improve Gutenberg for the WordPress community!

Copy link

github-actions bot commented Mar 11, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: SahilThakur02 <sahilthakur02@git.wordpress.org>
Co-authored-by: ajitbohra <ajitbohra@git.wordpress.org>
Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: annaghi <annabansaghi@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @SahilThakur02! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Mar 11, 2024
@annaghi
Copy link

annaghi commented Mar 11, 2024

Fixes #59529

Copy link
Member

@ajitbohra ajitbohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ajitbohra ajitbohra added [Package] Components /packages/components [Type] Bug An existing feature does not function as intended labels Mar 13, 2024
@SahilThakur02
Copy link
Contributor Author

@annaghi @ajitbohra How will my PR get merged? as it have been approved.

@mirka mirka added [Type] Code Quality Issues or PRs that relate to code quality and removed [Type] Bug An existing feature does not function as intended labels Mar 18, 2024
Copy link
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

For posterity, this code change affects the TextareaControl component, rather than the Heading block as mentioned in the testing instructions. You can find this by looking up where inputStyleNeutral is referenced in the codebase, and going up the chain until you hit a component. Then, you can run npm run storybook:dev to spin up the Storybook, and test any changes to the TextareaControl component. I've tested it this way and confirmed that it works as expected 👍

And don't worry, one of us will merge this PR for you. Please take a look at this comment to link your GitHub and WordPress.org accounts so we can properly credit you on this contribution. Thanks!

@mirka mirka changed the title Issue #59529 Removed extra closing curly brace in 'inputStyleNeutral'… TextareaControl: Remove extra closing curly brace in inputStyleNeutral Mar 18, 2024
@mirka mirka added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Mar 18, 2024
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Mar 18, 2024
@SahilThakur02
Copy link
Contributor Author

Linked my Github with Wordpress aswell @mirka @annaghi @ajitbohra

@mirka mirka merged commit c104cc3 into WordPress:trunk Mar 19, 2024
66 of 69 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.0 milestone Mar 19, 2024
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Mar 27, 2024
…al` (WordPress#59744)

Co-authored-by: SahilThakur02 <sahilthakur02@git.wordpress.org>
Co-authored-by: ajitbohra <ajitbohra@git.wordpress.org>
Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: annaghi <annabansaghi@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants