Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List Item: Add color support #59892

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

List Item: Add color support #59892

wants to merge 1 commit into from

Conversation

aaronrobertshaw
Copy link
Contributor

Fixes: #59854

What?

Adds color block support to the List Item block to match the parent List block.

Why?

The List Item block allows customizing typographic styles. This PR provides consistency for color styling and greater control for users.

How?

  • Opts into color block support
  • Only makes text and background color controls display by default to match List block's configuration

Testing Instructions

  1. Edit a post and add a list block with several items, some including links
  2. Select individual list item blocks and confirm you can customize colors appropriately
  3. Save and ensure the colors are correct on the frontend
  4. Switch to the Site Editor and navigate to Global Styles > Blocks > List Item
  5. Set some global colors for List Item blocks
  6. Save and switch back to the post editor
  7. Confirm the global styles are applied correctly and are overridden by the individual styles added earlier
  8. Double check colors again on the frontend

Screenshots or screencast

Screen.Recording.2024-03-15.at.5.35.32.PM.mp4

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Block] List Affects the List Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Mar 15, 2024
@aaronrobertshaw aaronrobertshaw self-assigned this Mar 15, 2024
@aaronrobertshaw aaronrobertshaw mentioned this pull request Mar 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@ryanwelcher ryanwelcher Awaiting requested review from ryanwelcher ryanwelcher is a code owner

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

@ndiego ndiego Awaiting requested review from ndiego ndiego is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@aaronrobertshaw aaronrobertshaw

Labels
[Block] List Affects the List Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance List Block for adding Style color option in list-item also
1 participant
@aaronrobertshaw