FlatTermSelector: Invalidate optimistic update if term creation fails #59945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @TMFHokies. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +7 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
fabiankaegy
approved these changes
Mar 18, 2024
|
Thanks for testing, @fabiankaegy! |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
…WordPress#59945) Unlinked contributors: TMFHokies. Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #39130.
PR fixes and improves error handling for the
FlatTermSelector. This prevents optimistic update artifacts from being displayed if the creation of a new term fails.Why?
The
FlatTermSelectoruses an internal state to handle optimistic updates and provide better UX. The state should be invalidated when WP data selectors fetch new values, but the invalidation logic didn't account for term creation errors.P.S. The component had no error handling until #53369.
How?
Add a call to
onUpdateTermswhen there's an error during the term creation.Testing Instructions
Test snippet
Testing Instructions for Keyboard
Same.
Screenshots or screencast
CleanShot.2024-03-18.at.12.53.30.mp4