Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update api-reference - data-bind--hidden is an incorrrect attribute - should be data-wp-bind--hidden #59955

Merged
merged 1 commit into from Mar 20, 2024

Conversation

tomepajk
Copy link
Contributor

@tomepajk tomepajk commented Mar 18, 2024

The examples have an error.

data-bind--hidden should be data-wp-bind--hidden

What?

Fixing a code error in a code example in the Interactivity API

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

The examples have an error. 

data-bind--hidden should be data-wp-bind--hidden
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @tomepajk.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: tomepajk.


To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Mar 18, 2024
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @tomepajk! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@skorasaurus skorasaurus added the [Type] Developer Documentation Documentation for developers label Mar 18, 2024
@t-hamano t-hamano self-requested a review March 20, 2024 02:14
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

@t-hamano t-hamano merged commit 4bb17c4 into WordPress:trunk Mar 20, 2024
59 of 61 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.0 milestone Mar 20, 2024
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Mar 27, 2024
The examples have an error. 

data-bind--hidden should be data-wp-bind--hidden

Unlinked contributors: tomepajk.

Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants