Update 'sidebar card' appearance #59997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +43 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
I thought my styles weren't building properly when I saw this. Maybe I'm missing the big picture, but this does not sit will in relation to the metrics of everything around it.
|
richtabor
added a commit
that referenced
this pull request
Mar 20, 2024
This reverts commit acef9ec.
|
Seeing the fuller picture Rich is sharing, I tend to agree, the heading levels here become a bit confusing. I appreciate the higher level effort to consolidate and unify multiple panels into what's closer to a single colophon that flows well, but let's see if we can't keep the existing panel font sizes until we have a clearer picture of heading levels. |
|
The font is the main one, but ellipsis icons aligning vertically is the other one coming to mind. |
|
The ellipsis icon didn't move in the referenced PR. It's still aligned with other icons in the Inspector: 
The one in the top bar should be tweaked though, I agree. |
|
Ah! Thanks. |
One of the two; I have a draft branch where I experimented with tweaks to try aligning these better. |
Is the plan to keep these aligned? I'm not following why we're changing the post card and not the block card. card.mp4 |
We should. There's a lot of attention from @ntsekouras focused on the page/post/template inspector summary card at the moment, I wonder if a light refresh of the block card can be part of that, for the same metrics? Let me know, otherwise I can hopefully try and dive into a PR. |
|
Yeah that has been on my mind, but like Joen says the document card (and other panels) is the current focus. I agree Block and Document cards should share metrics. Should/could they use the same component, so that they're always aligned? Otherwise I'll create a PR to try applying the document metrics to the block card when I find a moment. |
Unless someone suggests they can use the same component, I'll also be happy to make this PR. |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #59783.
What?
Update the appearance of the 'sidebar card' element.
Why?
To match the designs in #59689. Specifically to further establish the hierarchy of information.
How?
Screenshots
Additionally long titles are now truncated to two lines like so: