Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update google fonts font collection data url to the latest version available #60079

Merged
merged 1 commit into from Mar 21, 2024

Conversation

matiasbenedetto
Copy link
Contributor

What?

Update the Google Fonts JSON data URL to the latest deployed version in the WordPress.org CDN.

Why?

Reference:
https://meta.trac.wordpress.org/ticket/7522
WordPress/google-fonts-to-wordpress-collection#21

Copy link

github-actions bot commented Mar 21, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org>
Co-authored-by: mikachan <mikachan@git.wordpress.org>
Co-authored-by: creativecoder <grantmkin@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@matiasbenedetto matiasbenedetto added [Type] Code Quality Issues or PRs that relate to code quality [Feature] Font Library Backport to WP Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta labels Mar 21, 2024
@matiasbenedetto matiasbenedetto removed the Backport to WP Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Mar 21, 2024
Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@creativecoder
Copy link
Contributor

Do we need to do this in the Gutenberg plugin, since the updated Google fonts collection url is for WP 6.5?

@matiasbenedetto
Copy link
Contributor Author

Do we need to do this in the Gutenberg plugin, since the updated Google fonts collection url is for WP 6.5?

It's not crucial but still a good addition because of 2 reasons:

  • Gutenberg's font library code is up-to-date with core's wp_register_font_collection definition and this JSON file is in line with that.
  • This JSON file excludes some SVG previews not rendering as expected (reference)

@creativecoder
Copy link
Contributor

Thanks for clarifying!

@matiasbenedetto matiasbenedetto merged commit 31b04bc into trunk Mar 21, 2024
68 of 69 checks passed
@matiasbenedetto matiasbenedetto deleted the update/google-fonts-link branch March 21, 2024 15:14
@github-actions github-actions bot added this to the Gutenberg 18.1 milestone Mar 21, 2024
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Mar 27, 2024
…ailable (WordPress#60079)

Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org>
Co-authored-by: mikachan <mikachan@git.wordpress.org>
Co-authored-by: creativecoder <grantmkin@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Font Library [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants