Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Create Block] Update external template docs to include variants. #60095

Merged
merged 3 commits into from Mar 22, 2024

Conversation

ryanwelcher
Copy link
Contributor

What?

This PR adds missing documentation for the variants property in external project templates for the create-block package,

Why?

This is a powerful feature that needs explaining.

@ryanwelcher ryanwelcher added [Type] Developer Documentation Documentation for developers [Package] Create Block /packages/create-block labels Mar 21, 2024
@ryanwelcher ryanwelcher requested a review from bph March 21, 2024 20:33
@ryanwelcher ryanwelcher changed the title [Create Block] Update docs to include variants. [Create Block] Update external template docs to include variants. Mar 21, 2024
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ryanwelcher <welcher@git.wordpress.org>
Co-authored-by: justintadlock <greenshady@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ryanwelcher ryanwelcher enabled auto-merge (squash) March 21, 2024 23:27
Copy link
Contributor

@justintadlock justintadlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanwelcher ryanwelcher merged commit b194917 into trunk Mar 22, 2024
57 checks passed
@ryanwelcher ryanwelcher deleted the fix/update-create-block-docs branch March 22, 2024 02:20
@github-actions github-actions bot added this to the Gutenberg 18.1 milestone Mar 22, 2024
@gziolo
Copy link
Member

gziolo commented Mar 22, 2024

Nice, thank you for covering this missing feature.

carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Mar 27, 2024
…rdPress#60095)

* Update docs to include variants.

* Update packages/create-block/docs/external-template.md

* Update packages/create-block/docs/external-template.md

Co-authored-by: ryanwelcher <welcher@git.wordpress.org>
Co-authored-by: justintadlock <greenshady@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Create Block /packages/create-block [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants