Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Update hover color of editor document title #60113

Merged
merged 4 commits into from Mar 22, 2024

Conversation

nirav7707
Copy link
Contributor

What?

Follow up to:

Issue.60059.mp4

Why?

  • differentiate from synced assets

Update color of the document title of the editor from
--wp-block-synced-color to --wp-admin-theme-color to
differentiate from synced assets

issue: WordPress#60059
Copy link

github-actions bot commented Mar 22, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: nirav7707 <niravsherasiya7707@git.wordpress.org>
Co-authored-by: richtabor <richtabor@git.wordpress.org>
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Mar 22, 2024
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @nirav7707! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@richtabor richtabor requested a review from a team March 22, 2024 14:28
@richtabor
Copy link
Member

Thanks @nirav7707!

After testing, I pushed a few small adaptations.

We don't have a color change when viewing a synced element, I think we should do the same for the unsynced — that way it's a bit clearer that there is a color difference, and they're also more consistent.

Visual

document-title.mp4

@richtabor richtabor added [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Enhancement A suggestion for improvement. labels Mar 22, 2024
Copy link
Member

@richtabor richtabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jameskoster
Copy link
Contributor

Should we fix the hover color of the < Back button while we're here?

Screenshot 2024-03-22 at 15 16 07

@richtabor
Copy link
Member

Should we fix the hover color of the < Back button while we're here?

Sure thing. I made it $gray-900 in 7dfe9cc.

Copy link
Contributor

@jameskoster jameskoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I like the subtle animation.

@richtabor richtabor merged commit b4ebebb into WordPress:trunk Mar 22, 2024
56 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.1 milestone Mar 22, 2024
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Mar 27, 2024
* Editor: Update editor document title color on hover

Update color of the document title of the editor from
--wp-block-synced-color to --wp-admin-theme-color to
differentiate from synced assets

issue: WordPress#60059

* Remove hover color, add transition

* Fix back button hover color

---------

Co-authored-by: nirav7707 <niravsherasiya7707@git.wordpress.org>
Co-authored-by: richtabor <richtabor@git.wordpress.org>
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants