Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Fix @todo tags to follow standards in WordPress comments. #60148

Merged
merged 1 commit into from Mar 24, 2024

Conversation

interdevel
Copy link
Contributor

@interdevel interdevel commented Mar 24, 2024

What?

Ensure proper case for "@todo" tags in phpdocs.
Fixes #59539

Why?

There was invalid @todo tags (invalid: @todo: @todo @todo:)

How?

I've changed the @todo tags found in files to follow guidelines in https://developer.wordpress.org/coding-standards/inline-documentation-standards/php/#phpdoc-tags

PR done in WordCamp Torrelodones 2024 Core contributor table.

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: interdevel <interdevel@git.wordpress.org>
Co-authored-by: huzaifaalmesbah <huzaifaalmesbah@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Mar 24, 2024
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @interdevel! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

Copy link
Contributor

@cbravobernal cbravobernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbravobernal cbravobernal changed the title Changed: proper case for @todo tags Documentation: Fix @todo tags to follow standards in WordPress comments. Mar 24, 2024
@cbravobernal cbravobernal enabled auto-merge (squash) March 24, 2024 11:27
@cbravobernal cbravobernal merged commit aac90ca into WordPress:trunk Mar 24, 2024
58 of 70 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.1 milestone Mar 24, 2024
@@ -508,7 +508,7 @@ public function step( $node_to_process = self::PROCESS_NEXT_NODE ) {
* When moving on to the next node, therefore, if the bottom-most element
* on the stack is a void element, it must be closed.
*
* @TODO: Once self-closing foreign elements and BGSOUND are supported,
* @todo Once self-closing foreign elements and BGSOUND are supported,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should not be changing code inside the compat/*/html-api directory, since these files are maintained in Core and backported into Gutenberg. there's an exclusion rule in the linting to ignore this directory.

if someone wants to change the code style, it needs to happen in Core and be brought back. since this code is historic for the 6.4 release it should not be changed at all. thankfully it will be removed shortly so this doesn't matter, but please take note so that we don't create divergence between the repositories.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know about this detail, thanks for commenting!

carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Mar 27, 2024
Co-authored-by: interdevel <interdevel@git.wordpress.org>
Co-authored-by: huzaifaalmesbah <huzaifaalmesbah@git.wordpress.org>
@ellatrix ellatrix mentioned this pull request Apr 30, 2024
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

phpDocs improvements @todo tags
3 participants