Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font Library: install fonts in sequence to work around race condition #60180

Merged
merged 3 commits into from Mar 26, 2024
Merged

Font Library: install fonts in sequence to work around race condition #60180

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71aaf56
Font Library: install fonts in sequence to work around font directory…
creativecoder Mar 25, 2024
02eea0e
Update comment block to coding standards
getdave Mar 26, 2024
4d319ee
Fix linting
getdave Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 15 additions & 4 deletions packages/edit-site/src/components/global-styles/font-library-modal/utils/index.js
View file
Open in desktop
Expand Up @@ -234,10 +234,21 @@ export function makeFontFacesFormData( font ) {
}

export async function batchInstallFontFaces( fontFamilyId, fontFacesData ) {
const promises = fontFacesData.map( ( faceData ) =>
fetchInstallFontFace( fontFamilyId, faceData )
);
const responses = await Promise.allSettled( promises );
const responses = [];

// Uses the same response format as Promise.allSettled, but executes requests in sequence to work around a race condition
// that can cause an error when the fonts directory doesn't exist yet.
getdave marked this conversation as resolved.
Show resolved Hide resolved
for ( const faceData of fontFacesData ) {
try {
const response = await fetchInstallFontFace(
fontFamilyId,
faceData
);
responses.push( { status: 'fulfilled', value: response } );
} catch ( error ) {
responses.push( { status: 'rejected', reason: error } );
}
}

const results = {
errors: [],
Expand Down