CustomSelectControlV2: Match v1 stories to test legacy component #60182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Developer Documentation
mirka
commented
Mar 25, 2024
| @@ -43,45 +44,23 @@ const meta: Meta< typeof CustomSelect > = { | |||
| export default meta; | |||
|
|
|||
| const Template: StoryFn< typeof CustomSelect > = ( props ) => { | |||
| const [ fontSize, setFontSize ] = useState( props.options[ 0 ] ); | |||
| const [ value, setValue ] = useState( props.options[ 0 ] ); | |||
There was a problem hiding this comment.
Changing these names to be more generic.
| @@ -18,7 +23,7 @@ export default { | |||
| }, | |||
| }; | |||
|
|
|||
| export const Default = CustomSelectControl.bind( {} ); | |||
| export const Default: StoryFn = CustomSelectControl.bind( {} ); | |||
There was a problem hiding this comment.
Just adding this generic TS type annotation so this (formerly non-TS) file can be read by the other story file (TS) without erroring.
CustomSelectControl (v1) was never converted to TS, and it's going to be superseded by CustomSelectControlV2 Legacy soon, so it's ok.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.72 MB ℹ️ View Unchanged
|
tyxla
approved these changes
Mar 26, 2024
| WithLongLabels.args = V1Story.WithLongLabels.args; | ||
|
|
||
| export const WithHints = Template.bind( {} ); | ||
| WithHints.args = V1Story.WithHints.args; |
There was a problem hiding this comment.
In order to actually display the hints, we'll need the __experimentalShowSelectedHint prop:
Suggested change
| WithHints.args = V1Story.WithHints.args; | |
| WithHints.args = { | |
| ...V1Story.WithHints.args, | |
| __experimentalShowSelectedHint: true, | |
| }; |
Here are some before/after screenshots:
Without the __experimentalShowSelectedHint prop:
With the __experimentalShowSelectedHint prop:
There was a problem hiding this comment.
Just saw #60183, lol. Feel free to disregard!
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
…dPress#60182) Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
…dPress#60182) Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #55023
What?
Reuse the Storybook story props for CustomSelectControl (v1) in the stories for CustomSelectControlV2 legacy so we can more accurately test how styles and functionality match up.
Why?
Although CustomSelectControlV2 legacy will soon completely replace CustomSelectControl (v1), we need this duplicated testing ground right now so we can brush things up and bring it up to parity.
Testing Instructions
The stories for CustomSelectControlV2 Legacy should match the story settings for CustomSelectControl (v1). You may notice styling and functional differences at this point, but that's ok. We will start fixing them in separate PRs.