Navigation Block: Add test coverage to check that post content is not removed #60189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
approved these changes
Mar 26, 2024
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
…e nav menu (WordPress#60189) Co-authored-by: ockham <bernhard-reiter@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
…e nav menu (WordPress#60189) Co-authored-by: ockham <bernhard-reiter@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add a unit test to cover #59991 (fixed in #60071). The issue was that if a navigation menu was renamed (but not changed otherwise), its content was accidentally deleted.
The reason for this was related to the
stdClassobject that's used to communicate required changes towp_update_post: If itspost_contentfield was not set (indicating no changes were to be made),block_core_navigation_update_ignore_hooked_blocks_metawould accidentally set that field to an empty string (meaning it would be replaced by that) -- thus causing loss of data.Why?
To prevent against regressions.
How?
Verify that if the
stdClassobject'spost_contentis unset before runningblock_core_navigation_update_ignore_hooked_blocks_meta, it also is afterwards.Testing Instructions
Verify that tests pass.
To verify that the test covers the issue, revert 7b6ac8d (i.e. #60071), rebuild Gutenberg, and re-run the tests. They should now fail.