Fix rendering PluginTemplateSettingPanel when we're editing a template #60215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
|
Size Change: +25 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Thanks, Nik! The fix works as expected.
Here's the code I used for testing:
const { createElement: el } = wp.element;
const registerPlugin = wp.plugins.registerPlugin;
const PluginTemplateSettingPanel = wp.editSite.PluginTemplateSettingPanel;
function TestPluginTemplateSettingPanel() {
return el(
PluginTemplateSettingPanel,
{},
el( 'p', {}, `Hello templates!` )
);
}
registerPlugin( 'test-post-publish-panel', {
icon: 'smiley',
render: TestPluginTemplateSettingPanel,
} );| @@ -115,6 +116,7 @@ export default function TemplatePanel() { | |||
| > | |||
| <TemplateAreas /> | |||
| </PostCardPanel> | |||
| <PluginTemplateSettingPanel.Slot /> | |||
There was a problem hiding this comment.
Should we move the slot below the "Transform into:" panel to retain the same position as on the trunk?
There was a problem hiding this comment.
I think not because initially was below the 'template card' and that changed unintentionally.. If someone reports something, we could revisit. The goal though would be to use PluginDocumentSettingPanel eventually.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ntsekouras
deleted the
fix/PluginTemplateSettingPanel-render-on-templates
branch
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
WordPress#60215) Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
WordPress#60215) Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In #50257 we introduced a new slot in Template Sidebar below the main information like the Template Card. At some point when we added the ability to also edit the page, this slot would render in both cases(page and template) which was not the intent.
Discussions have started about how to migrate it's usage and use internally PluginDocumentSettingPanel, but for now we can fix the rendering.
Testing Instructions
Code example: