Simplify template reset language #60256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -25 B (0%) Total Size: 1.73 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 9a41e6c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8537462802
|
|
I like "Reset" more than "clear customizations" . Could maybe extend to "Reset to default" if needed. |
|
Not a strong opinion, but now feels like the moment to be bold, and potentially row back based on feedback if needed. We could add the 'to default' language to the confirmdialog?
|
|
😭 Thank you for working on this! This inconsistency has been frustrating and confusing, particularly for destructive actions. Here's some feedback for you: Considering adding a heading to the modal Should we add a "Be careful" style heading similar to this approach with removing query loop blocks? #58138 I'm not sold on this but, again, am thinking about consistency across the experience. Resetting styles has no modal Update the snackbar notice to say reset For resetting from Data Views for templates, I also think we should match the snackbar notice to say "reset" rather than "reverted": Consider making reset red Another minor note but should "reset" be red, similar to "trash" on Posts > All Posts:
|
I believe maintaining consistency in the flow is most important. Minor differences in modal composition, such as the presence or absence of a title, seem acceptable to me. A "Be careful" warning seems excessive in this particular scenario. Additionally, a generic "Reset template" heading might be redundant, considering the accompanying copy directly below.
This PR focusses on resetting templates, we can follow-up to address styles 👍
Good catch! I'll push a fix.
I quite like using color to highlight 'danger zone' actions – generally those that cannot be undone. So in this case I would consider making the 'Reset' button in the modal red. That said, we may need to revisit how we apply destructive colors at the component level before committing to this change. Colors can have different meanings in different cultures, and red doesn't always represent 'Danger'. It's also a detail to apply holistically to all such flows. |
|
Sounds good across the board. Excited about this! |
|
Is the copy agreed upon for this one, so we can code review? |
|
Yep, I'd echo a simple "Reset" for the button to echo Jay's comments. |
ntsekouras
force-pushed
the
update/template-reset-language
branch
from
021f490
to
4d687d8
Compare
|
Thanks Nik. |
richtabor
reviewed
Apr 2, 2024
|
I'm not sure we need to be quite so explicit here as there is plenty of context, plus the confirmation modal (which is not present for styles). |
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: SaxonF <saxonafletcher@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
colorful-tones
added
General Interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has come up a couple of times – notably in #46859 – and with the long runway to 6.6 now feels like a potentially good time to try adjusting the language around clearing template customizations.
What?
Buttonlabels inConfirmDialogs now read: "Reset"Why?
ConfirmDialogshould eliminate any potential confusion.Testing Instructions
Reset a theme template from any of the locations in which it is possible to do so:
Observe the updated language.