Reset specificity of body selector when processing with postcss. #60266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
added
[Type] Bug
tellthemachines
requested review from
ellatrix,
ramonjd,
andrewserong and
aaronrobertshaw
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +14 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
Good catch! This is testing nicely for me, and I notice that other :where(body ... related rules are unaffected (e.g. base layout styles), so I didn't run into any issues with it.
Would it be worth adding a test to the test file for this function? Since it can be thrown a variety of CSS, I'm wondering if it's possible for there to be peculiar edges cases 🤔
Since this fixes quite a visible bug, I won't let those comments hold up getting this in, though.
LGTM!
| @@ -19,6 +19,7 @@ function transformStyle( | |||
| return css; | |||
| } | |||
|
|
|||
| const postcssFriendlyCSS = css.replace( ':where(body)', 'body' ); | |||
There was a problem hiding this comment.
Would :where(body) ever be chained after another rule, i.e. .my-class-name:where(body)? If so, the result might not be valid CSS. I imagine that would be very edge-case territory as it's probably quite unlikely anyone would do that?
There was a problem hiding this comment.
Hmm yeah I'm not sure that will be much of a problem, because any unchanged selector with :where(body) would get the scoping selector prepended to it, so it would only work if the scoping selector happened to be attached to the html element. That's pretty unlikely to happen 😅
|
Thanks for reviewing @andrewserong!
Yeah might be worth doing, but good idea to do it as a follow-up! |
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
…dPress#60266) Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes a bug introduced in #60106, in which global styles selectors were wrapped in
:where()to reduce their specificity.When the editor isn't iframed, its styles are wrapped in a scoping selector using this postcss plugin . The plugin is smart enough to recognise and replace root selectors such as
bodyandhtml, but it doesn't work for:where(body).To fix this, we can replace any occurrences of
:where(body)withbodybefore feeding them into postcss. (We don't seem to usehtmlfor global styles which is why I haven't added it.)Testing Instructions
.editor-styles-wrapper: