Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CSS which truncates long texts inside suggestions list #60319

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

n2erjo00
Copy link
Contributor

What?

This PR removes horizontal scrolling from link suggestion list which appears when adding link to Image block.

Why?

Closes #58497

Horizontal scrolling creates accessibility concerns.
It is also nice that feel and function between different suggestions lists are same

How?

With the power of CSS.

Testing Instructions

  1. Open a post or page.
  2. Insert a Image block.
  3. Add link to that Image block. Navigate the list of suggestion using keyboards

It should be noted that you need have page(s) or post(s) with really long titles to see any

Testing Instructions for Keyboard

Screenshots or screencast

Before
Screenshot 2024-03-30 at 13 09 04

After
Screenshot 2024-03-30 at 13 07 17

@n2erjo00 n2erjo00 requested a review from ellatrix as a code owner March 30, 2024 11:16
Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: n2erjo00 <n2erjo00@git.wordpress.org>
Co-authored-by: afercia <afercia@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image: Link UI: horizontal scroll hides suggested links when using the keyboard
1 participant