-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List view: adjust performance test #60332
base: trunk
Are you sure you want to change the base?
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: 0 B Total Size: 1.72 MB ℹ️ View Unchanged
|
Similarly to #60320, this also doesn't change the metrics at all 🤔 @youknowriad Am I maybe doing something wrong here? It's almost impossible that this wouldn't increase the metric because there's many more items to render in the list view. |
I can't tell exactly, maybe it's not impacting because the list view has some built-in lazy rendering (only things in view). Also, it's not reliable to compare numbers between multiple PRs. |
What?
Why?
It's good to bring some variety into this test. For example heading content is previewed in the list view, whereas paragraphs are not.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast