Editor: Move PluginPostPublishPanel and PluginPrePublishPanel to editor package #60344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +62 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Thank you, @ntsekouras!
The changes work as expected. I used the publish-panel.js example plugin for testing.
The failing unit test will need fixing before we can land this.
ntsekouras
force-pushed
the
move/pre-post-publish-panels-to-editor-package
branch
from
98988f6
to
bfe1784
Compare
youknowriad
approved these changes
Apr 2, 2024
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
…or package (WordPress#60344) Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
|
I see the editor package docs and slotfills reference still using the import from I guess there's no hurry before 6.6, since even afterward the old import will work for two core versions. But does it make sense to change such required doc-changes somewhere? |
|
In general, we used to make the changes to the documentation as we make the changes to the code. So we could make them right now. It's true that it might confuse some developers but I feel like this is a problem that should be solved in the site (have a version selector or something) |
|
Thanks for the information, then I will make a PR for docs. |
gaambo
added a commit
to gaambo/gutenberg
that referenced
this pull request
Apr 10, 2024
follow up to WordPress#60344
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Related: #52632, #59878
Extracted from: #60289
This PR moves PluginPostPublishPanel and PluginPrePublishPanel to editor package. This is a prerequisite for unifying the publishing flow between post and site editors.
Testing Instructions
edit-postpackages works as beforeeditorpackage.Example code:
Notes
The editor package doesn't auto generate docs and will explore this separately. I'll have a PR soon for that.