Add null check to prevent errors in get_block_template filter
#60491
Conversation
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| @@ -71,6 +71,9 @@ function gutenberg_replace_pattern_blocks_get_block_templates( $templates ) { | |||
| } | |||
|
|
|||
| function gutenberg_replace_pattern_blocks_get_block_template( $template ) { | |||
| if ( null === $template ) { | |||
| return $template; | |||
| } | |||
There was a problem hiding this comment.
To me that sounds like there's a bug in the get_block_template filter, which should be called at all for null.
|
Related, this fixes a fatal error documented in #60638 |
colorful-tones
added
[Type] Performance
|
I've added the |
What?
This PR adds null check to prevent
Error : Attempt to assign property "content" on nullingutenberg_replace_pattern_blocks_get_block_templatefilter introduced in #60349.Why?
Since the first param
$templateisWP_Block_Templateornullif there isn't one.https://github.com/WordPress/wordpress-develop/blob/8d0aed455b1790c5d51386f7675d9e8d68e48edf/src/wp-includes/block-template-utils.php#L1113
How?
Added null check before assigning the content.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast