New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
useBlockSync: avoid replacing same blocks #60541
Conversation
Size Change: +25 B (0%) Total Size: 1.73 MB
ℹ️ View Unchanged
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
1547c09
to
1838ab5
Compare
What?
Currently
setControlledBlocks
is often called twice on load for exactly the same array of blocks. This seems to happen because there is a second effect that runs when a block becomes controlled, though blocks may already have been set by an effect that also sets thisisControlled
flag.Why?
The amount of calls to the
setControlledBlocks
is reduce from 38 to 24 times for the TT4 business index template.How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast