Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure display name is correctly formatted in comments #60579

Merged
merged 1 commit into from Apr 9, 2024

Conversation

tellthemachines
Copy link
Contributor

What?

Display name in the comments template Avatar is used in the image description so should be correctly formatted.

Testing Instructions

Check Avatar block in Post Comments works as expected.

@tellthemachines tellthemachines added [Type] Bug An existing feature does not function as intended Backport to Gutenberg Minor Release Pull request that needs to be backported to a Gutenberg minor release labels Apr 9, 2024
@tellthemachines tellthemachines self-assigned this Apr 9, 2024
Copy link
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

github-actions bot commented Apr 9, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: johnbillion <johnbillion@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@tellthemachines tellthemachines merged commit 2e4d71e into trunk Apr 9, 2024
71 checks passed
@tellthemachines tellthemachines deleted the fix/display-name branch April 9, 2024 05:46
@github-actions github-actions bot added this to the Gutenberg 18.2 milestone Apr 9, 2024
tellthemachines added a commit that referenced this pull request Apr 9, 2024
…block. (#60579)

Co-authored-by: johnbillion <johnbillion@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
tellthemachines added a commit that referenced this pull request Apr 9, 2024
…block. (#60579)

Co-authored-by: johnbillion <johnbillion@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
tellthemachines added a commit that referenced this pull request Apr 9, 2024
…block. (#60579)

Co-authored-by: johnbillion <johnbillion@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
tellthemachines added a commit that referenced this pull request Apr 9, 2024
…block. (#60579)

Co-authored-by: johnbillion <johnbillion@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
tellthemachines added a commit that referenced this pull request Apr 9, 2024
…block. (#60579)

Co-authored-by: johnbillion <johnbillion@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
tellthemachines added a commit that referenced this pull request Apr 9, 2024
…block. (#60579)

Co-authored-by: johnbillion <johnbillion@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
@ramonjd ramonjd added the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Apr 9, 2024
ramonjd pushed a commit that referenced this pull request Apr 9, 2024
…block. (#60579)

Co-authored-by: johnbillion <johnbillion@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
@ramonjd
Copy link
Member

ramonjd commented Apr 9, 2024

I just cherry-picked this PR to the release/18.1 branch to get it included in the next release: 46cd05a

@ramonjd ramonjd removed the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Apr 9, 2024
tellthemachines added a commit that referenced this pull request Apr 9, 2024
…block. (#60579)

Co-authored-by: johnbillion <johnbillion@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
cbravobernal pushed a commit to garridinsi/gutenberg that referenced this pull request Apr 9, 2024
…block. (WordPress#60579)

Co-authored-by: johnbillion <johnbillion@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport to Gutenberg Minor Release Pull request that needs to be backported to a Gutenberg minor release [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants