Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum required PHP version to 7.2. #60714

Merged
merged 1 commit into from Apr 23, 2024

Conversation

anton-vlasenko
Copy link
Contributor

@anton-vlasenko anton-vlasenko commented Apr 12, 2024

What?

  • Bumps the plugin's minimum PHP version from 7.0 to 7.2.
  • Bumps PHPCS testVersion from 7.0- to 7.2-.
  • Bumps the PHPUnit test Test with previous WP version from php: 7.0 to php: 7.2.

Fixes #60680.

Why?

WordPress Core parity.

WordPress 6.6.0's minimum supported PHP version is/will be 7.2.

How?

Modifies the plugin header's Requires PHP: from 7.0 to 7.2.

Testing Instructions

  1. Change your local test environment to PHP 7.0 (7.1) and WordPress 6.6-alpha.
  2. Install and activate the Gutenberg 18.1.x plugin.
  3. Open the gutenberg.php file, and in the file's DocBlock change Requires PHP: back to 7.2.
    Expected: Stays activated, bulk actions disabled, and a notice appears:

This plugin does not work with your version of PHP. Learn more about updating PHP.

  1. Deactivate the plugin.
    Expected: Bulk edit is disabled; Cannot Activate is displayed but not clickable; notice appears:

This plugin does not work with your version of PHP. Learn more about updating PHP.

@anton-vlasenko anton-vlasenko marked this pull request as ready for review April 12, 2024 18:08
Copy link

github-actions bot commented Apr 12, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: anton-vlasenko <antonvlasenko@git.wordpress.org>
Co-authored-by: johnbillion <johnbillion@git.wordpress.org>
Co-authored-by: Soean <soean@git.wordpress.org>
Co-authored-by: talldan <talldanwp@git.wordpress.org>
Co-authored-by: ironprogrammer <ironprogrammer@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@anton-vlasenko anton-vlasenko added [Type] Enhancement A suggestion for improvement. Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts labels Apr 12, 2024
@anton-vlasenko anton-vlasenko force-pushed the fix/drop-support-for-php-70-and-71 branch from fc75420 to d1d3fbe Compare April 12, 2024 20:20
@anton-vlasenko
Copy link
Contributor Author

anton-vlasenko commented Apr 12, 2024

Let's not merge this one now; I need some time to test it to ensure it works as expected.

This question needs to be discussed first: #60680 (comment)

@anton-vlasenko anton-vlasenko force-pushed the fix/drop-support-for-php-70-and-71 branch from d45d52f to c4c5113 Compare April 23, 2024 19:52
@anton-vlasenko anton-vlasenko enabled auto-merge (squash) April 23, 2024 19:53
@anton-vlasenko
Copy link
Contributor Author

anton-vlasenko commented Apr 23, 2024

The PR has received two approvals.
I think this is sufficient consensus, considering the process is similar to #52344.
I will proceed with the version bump as soon as the CI jobs pass.

@anton-vlasenko anton-vlasenko merged commit a9fbf74 into trunk Apr 23, 2024
60 checks passed
@anton-vlasenko anton-vlasenko deleted the fix/drop-support-for-php-70-and-71 branch April 23, 2024 20:32
@github-actions github-actions bot added this to the Gutenberg 18.3 milestone Apr 23, 2024
@anton-vlasenko
Copy link
Contributor Author

Thank you for approving the PR, @johnbillion and @Soean!
The version has been bumped.

colorful-tones pushed a commit that referenced this pull request Apr 24, 2024
Bump minimum required PHP version to 7.2.

Co-authored-by: anton-vlasenko <antonvlasenko@git.wordpress.org>
Co-authored-by: johnbillion <johnbillion@git.wordpress.org>
Co-authored-by: Soean <soean@git.wordpress.org>
Co-authored-by: talldan <talldanwp@git.wordpress.org>
Co-authored-by: ironprogrammer <ironprogrammer@git.wordpress.org>
@colorful-tones
Copy link
Member

Note: this is being included in the Gutenberg 18.2 release, because there was a conflict during release and it just seemed easier path forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase the PHP minimum supported version to 7.2
4 participants