New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block bindings: don't use hooks (with value setting example) #60722
Closed
ellatrix
wants to merge
3
commits into
add/support-for-editing-in-block-bindings
from
try/move-block-binding-hook
Closed
Block bindings: don't use hooks (with value setting example) #60722
ellatrix
wants to merge
3
commits into
add/support-for-editing-in-block-bindings
from
try/move-block-binding-hook
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: -179 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
ellatrix
changed the title
Block bindings: don't use hooks
Block bindings: don't use hooks (with value setting example)
Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I don't see much reason for the binding source API to be a hook. We can add use a simpler get function that selects data from the store and a set function dispatch the action.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast