New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: Make content locking related selectors private. #60827
Update: Make content locking related selectors private. #60827
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +233 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
The change might count as a breaking change if unstable selectors shipped with WP 6.5, though I doubt it will cause an actual breakage. |
I didn't check, but I assumed they shipped with 6.5. If so, we should leave some deprecations, but how about we make them more aggressive than usual? Hollow out the functions so that they just return an empty value, log through the |
Follows feedback from @mcsf at #57737 (comment) and makes the content-locking related selectors private instead of public but unstable.
Testing Instructions
Verified end to end tests are passing (they have coverage for content locking).
Pasted the following code in the editor:
Verified content locking is working, that I could press "Modify" to temporarily edit as blocks, and that when I unfocus for a block outside of the locked block the focus mode is correctly reverted.