New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor: Do not render publish time and post status panels in design post types #60857
Editor: Do not render publish time and post status panels in design post types #60857
Conversation
NAVIGATION_POST_TYPE, | ||
} from '../../store/constants'; | ||
|
||
const DESIGN_POST_TYPES = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're starting to use this pattern in lots of places and it would be good to handle this more gracefully (maybe a selector). Let's see to it separately though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a post-type setting indicating that it's intended for the design? It doesn't need to be a public API, just like - _builtin
.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +71 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
371fb00
to
baa1fd3
Compare
What?
With the unification efforts of the editors (post and site) we expose some information in some post types (patterns, templates, template parts) that don't make much sense and might have unexpected results and lead to confusion.
Examples are:
Below is trunk:
Testing Instructions