-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typography Panel: Use simple labels #60886
Conversation
Size Change: +38 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR and for updating tests.
I think the simple labels gathered the most consensus on the issue #60886 so ✅
Block
![Screenshot 2024-04-19 at 1 24 50 pm](https://private-user-images.githubusercontent.com/6458278/323822770-709d051d-8528-4f41-971b-78b52816c1ff.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQxNjE4MjgsIm5iZiI6MTcyNDE2MTUyOCwicGF0aCI6Ii82NDU4Mjc4LzMyMzgyMjc3MC03MDlkMDUxZC04NTI4LTRmNDEtOTcxYi03OGI1MjgxNmMxZmYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgyMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MjBUMTM0NTI4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZGY2Y2Y1ZGQ1MjkwYWY5ZGQwN2JiNmQ1YTIwYmM4YzhiZGRkZTY2NGMyYTQ4ZjY1MDg0ZDc2MzMxZjVlZTE1MSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.lbb9KMRE4-lbCv39kVGJUgEzvBi4kKe--bw9C-IvfJE)
Global styles
![Screenshot 2024-04-19 at 1 27 15 pm](https://private-user-images.githubusercontent.com/6458278/323822741-979a4d9d-ea92-4a79-ab85-8f1578f9fcb4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQxNjE4MjgsIm5iZiI6MTcyNDE2MTUyOCwicGF0aCI6Ii82NDU4Mjc4LzMyMzgyMjc0MS05NzlhNGQ5ZC1lYTkyLTRhNzktYWI4NS04ZjE1NzhmOWZjYjQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgyMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MjBUMTM0NTI4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NGNhMGMwMzRjMDhjZDk0ZjE4MTI4ODA3NDVhYTQwZThjZGU4Mjk3OGFlYzEwMGJkMjkyYTVmNjg2ZTI0YzExNiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.nlBN4D6J8dkrfUs6YnGANlyJIb-xwTa74Kc4N94NAAA)
Very nice 🚀 |
Fixes #60547
What?
This PR simplifies the labels of the tools panel popover in the Typography panel. This should perfectly match the label in the actual UIs.
Why?
Mismatches between option names and actual control labels confuse users.
How?
I use the simple label that received the most feedback in #60547. As mentioned in this comment, the context of typography already exists, so there seems to be no problem from an accessibility perspective.
Testing Instructions
There are currently no blocks that support textColumn, which is part of the typography support, so add the code below somewhere in
gutenberg.php
to temporarily add textColumn support to the paragraph block.Screenshots or screencast