Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX[#60958]: Code Editor background height #60960

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

DSGND
Copy link

@DSGND DSGND commented Apr 22, 2024

What?

Fix issue #60958

How?

Remove min-height: 100%; in .edit-site-code-editor class

Copy link

github-actions bot commented Apr 22, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @hello@dzgnd.studio.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: hello@dzgnd.studio.

Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: DSGND <d-signed@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Apr 22, 2024
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @DSGND! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@DSGND
Copy link
Author

DSGND commented Apr 22, 2024

My WP account is D SIGNED

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Package] Edit Site /packages/edit-site labels Apr 22, 2024
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I also tried a similar fix in #51697 😄

@@ -1,7 +1,6 @@
.edit-site-code-editor {
position: relative;
width: 100%;
min-height: 100%;
background-color: $white;
Copy link
Contributor

@t-hamano t-hamano Apr 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
background-color: $white;
flex-glow: 1;
background-color: $white;

Without flex-grow, the background color would not stretch to its full height when there is little content.

without-flex-glow

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this proposal using flex-grow: 1 fixes the issue and also allow the background-color to cover the entire space when there is less content.

@t-hamano t-hamano added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Apr 22, 2024
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Apr 22, 2024
@t-hamano t-hamano linked an issue Apr 22, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Edit Site /packages/edit-site [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit site in code editor mode
3 participants