Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: Remove unnecessary __experimentalStyle #60965

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

t-hamano
Copy link
Contributor

@t-hamano t-hamano commented Apr 22, 2024

Closes #59142
Rleated to #51710, #52579

What?

This PR removes unnecessary __experimentalStyle from the Navigation menu.

Why?

From what I've researched, this is an accidental regression caused by the timing of two PRs being merged.

Below are the PRs related to this issue and the dates and times they were merged.

As you can see, the times when the two PRs were merged are very close. Perhaps the latter PR did not include the former PR, so __experimentalStyle was added unintentionally.

Testing Instructions

Since the stylesheet already exists, there will be no side effects of deleting it. As shown below, color: inherit; should still be applied to links in the navigation block.

trunk This PR
trunk this_pr

@t-hamano t-hamano added [Type] Regression Related to a regression in the latest release [Block] Navigation Affects the Navigation Block labels Apr 22, 2024
@t-hamano t-hamano self-assigned this Apr 22, 2024
@t-hamano t-hamano marked this pull request as ready for review April 22, 2024 14:36
Copy link

github-actions bot commented Apr 22, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: MaggieCabrera <onemaggie@git.wordpress.org>
Co-authored-by: nextgenthemes <nico23@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@MaggieCabrera MaggieCabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that looks correct to me. I believe we should have this covered with e2e tests too

@t-hamano
Copy link
Contributor Author

@MaggieCabrera Thanks for the review!

I believe we should have this covered with e2e tests too

Isn't the default color tested here? This PR only removes duplicate color:inherit, so it might be difficult to verify this with E2E tests.

@t-hamano
Copy link
Contributor Author

For now, I would like to merge this PR. If we need additional e2e testis, I'd be happy to do that as a follow-up.

@t-hamano t-hamano merged commit f083b46 into trunk Apr 23, 2024
70 checks passed
@t-hamano t-hamano deleted the navigation/remove-experimental-style branch April 23, 2024 03:55
@github-actions github-actions bot added this to the Gutenberg 18.3 milestone Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation inline CSS gets injected despite wp_dequeue_style( 'wp-block-navigation' );
2 participants